Repository navigation
fix:Keep subtitles visible during Next-up preview - #1150
Merged
PartyDonut merged 3 commits intoOct 25, 2026
Merged
Conversation
Haryk96
marked this pull request as ready for review
September 23, 2026 19:41
Haryk96
changed the title
Contributor
Author
|
@PartyDonut can you please take a look? Thanks a lot 😊 |
# Conflicts: # lib/screens/video_player/video_player_controls.dart
PartyDonut
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Keep subtitles visible when the Next-up split screen appears. The player now fades the controls while leaving the existing subtitle widget visible over the reduced video.
Issue Being Fixed
Near the end of an episode, Next-up faded the controls layer. That layer also contained subtitles, so dialogue continued playing without visible captions.
Screenshots / Recordings
Before
After
Tested On
Checklist